search

gersilex / apcupsd-docker

apcupsd in a container; can trigger arbitrary commands on the Docker host
https://hub.docker.com/r/gersilex/apcupsd
MIT License
25 stars 12 forks source link

Include host-trigger-check.sh in Dockerfile #2

Closed Cyber1000 closed 6 years ago

Cyber1000 commented 6 years ago

Hi,

I think you forgot to include host-trigger-check.sh in Dockerfile, at least the Readme says, that I should copy it from the dockercontainer to the host.

Thanks for the container, have a nice day, Cyber1000

gersilex commented 6 years ago

Hi @Cyber1000 ! Thank you very much for this issue. I wouldn't add the file to the Docker image, because it is not useful inside a Docker container. I also honestly don't know why I mounted the file into the container at the docker run part, so I removed it.

I extended the README.md so that it instructs to download the host-trigger-check.sh from the Github repository, instead of the Docker image.

If you want, feel free to check out the new Readme and tell me if it makes you happy or something is still unclear. :)

Have a nice day as well!

Cyber1000 commented 6 years ago

Sorry for the late reply, too much work ... Yeah I think that's the best solution, thanks for your fast response