search

gerstrong / Commander-Genius

Modern Interpreter for the Commander Keen (Vorticon Dreams and Galaxy) and also Cosmos Cosmic Adventure games. This is a mirror repo: The main gitlab repository is at: https://gitlab.com/Dringgstein/Commander-Genius
http://clonekeenplus.sourceforge.net/
Other
192 stars 36 forks source link

[Warnings] build unlzexe with clang++ 13 or 14 #369

Closed LowLevelMahn closed 1 year ago

LowLevelMahn commented 2 years ago 
unlzexe.cpp:324:20: warning: result of comparison of constant 65536 with expression of type 'WORD' (aka 'unsigned short') is always true [-Wtautological-constant-out-of-range-compare]
    } while(rel_seg!=(0xf000+0x1000));
            ~~~~~~~^ ~~~~~~~~~~~~~~~

and the version print needs blanks before after the macro, to be C++11 conform

printf("UNLZEXE Ver. " VERSION "\n"); /* v0.6 */

gerstrong commented 1 year ago

confirmed.

gerstrong commented 1 year ago

Fixed here: https://github.com/gerstrong/Commander-Genius/commit/36a22095f4c2a5dfd2afab3137f126767ff28ec1