search

gertjanssenswillen / processmapR

!! repository moved to https://github.com/bupaverse/processmapR !! This repo is read-only from now one.
Other
7 stars 9 forks source link

plotly_dotted_chart for relative view #38

Open frkbr opened 5 years ago

frkbr commented 5 years ago

Thanks for your continuing development of bupaR!

Here's a suggestion for the plotly_dotted_chart()function.

Log %>% plotly_dotted_chart() seems to only work without arguments.

If I enter plotly_dotted_chart(x = "relative", sort = "duration") I get an error, saying there's an unused argument.

Suggestion 1: Make plotly_dotted_chart available for relative dotted charts as well. This would be very useful, since the user can then get the Case-ID from long-running cases directly from the graph and investigate specific cases further in the raw data.

Suggestion 2: Create a function plotly_trace_explorer. This would be useful too, since the trace_explorer graph is sometimes hard to read if there are many traces, due to the shortening of activity names. The tooltips from plotly would alleviate this.

I'm using the CRAN-versions (v 0.4.1 from bupaR and v 0.3.2 from processmapR).

gertjanssenswillen commented 5 years ago

Thanks a lot for noticing this. Naturally, these arguments should be accepted also for the plotly version. I just pushed it to github. The plotly variant for trace explorer will follow later today.

gertjanssenswillen commented 5 years ago

plotly_trace_explorer added, but doesn't work optimally yet.

  1. Facets each have equal height, irrespective of the number of traces they contain
  2. It's not possible to zoom in on a single facet panel, all panels are synchronized.

I'll further look into these issues. Probably the plotly version which have to be defined in a different way.