search

gertjanssenswillen / processmapR

!! repository moved to https://github.com/bupaverse/processmapR !! This repo is read-only from now one.
Other
7 stars 9 forks source link

process_map #5

Closed Nipi closed 6 years ago

Nipi commented 6 years ago

Hi, Gert. I found that process_map function doesn't work well when type = perfomance().

Nodes are numbers instead of "actions" and the starting node seems to be a final node.

cattura

gertjanssenswillen commented 6 years ago

Strange. Is it possible to share (a subset of) the data you have, so I can see what's wrong? If so, send them to gert.janssenswillen@uhasselt.be. If not, I'll think of some tests you can do to find the problem.

In any case, thanks for highlighting these issues!

Nipi commented 6 years ago

Hello Gert, I am sorry, but it is not possible to share a subset of data at the moment.

But I used this function with default type and it works well.... it seems to be a problem with type = performance ().

In addition, in the portion of graph that I removed from screenshot is possible to read the "actions". The rappresentation I obtained from processmapR is mixed: some nodes are actions and others are numbers...but I don't have numbers as activity_id in my data.

Thanks a lot!

gertjanssenswillen commented 6 years ago

Ok, thanks anyhow. I hope to find the problem very soon.

gertjanssenswillen commented 6 years ago

I made a separate branch to test some things. Can you install this version of processmapR (in a clean R session):

devtools::install_github("gertjanssenswillen/processmapR", ref = "process_map_dev")

and show me the results of the process_map function? It will be a list with 3 data.frames (without confidential information).

Nipi commented 6 years ago

here you are, thanks 4 the support. You can find the same process map with default type and type = performance.

gert.zip

gert_performance.zip

gertjanssenswillen commented 6 years ago

In your data, are there any missing values for the timestamp column?

Nipi commented 6 years ago

Yes

gertjanssenswillen commented 6 years ago

Good, so I assume that's the problem. I will fix the code such that it can handle these missing values.

gertjanssenswillen commented 6 years ago

I pushed some fixes to the separate branch. Could you try if the result is improved now? (sorry I don't have an appropriate event log right now to test it myself)

gertjanssenswillen commented 6 years ago

I have pushed another fix which I think will solve the issues with the arcs.

Nipi commented 6 years ago

The problem is solved! Thanks a lot!

gertjanssenswillen commented 6 years ago

Thanks to you for highlighting it! I will merge the branch back with the master branch.

gertjanssenswillen commented 6 years ago

Issue solved by pull request #6