gertkjerslev / OctoPrint-Nexmonotifier

Octoprint plugin for print completion notifications using Nexmo SMS gateway
GNU Affero General Public License v3.0
1 stars 0 forks source link

Nexmo US SMS requires valid numeric FROM field #1

Closed danrohtbart closed 5 years ago

danrohtbart commented 5 years ago

Hi there, your solution is awesome. Thank you so much for doing this. Unfortunately, the issue in the US is that a valid source phone number is required in the FROM field... but in octoprint_nexmonotifier/init.py line 60, the text "Nexmonotifier" is hardcoded into the From field. As a result, the octoprint.log shows octoprint.plugins.nexmonotifier - INFO - Illegal Sender Address - rejected

Can you please make the From field available in the UI, so the OctoPrint user can put in one of their valid Nexmo phone numbers?

https://help.nexmo.com/hc/en-us/articles/204017023-USA-SMS-Features-Restrictions

gertkjerslev commented 5 years ago

I have now added the field for Sender ID and is ready in version 1.1. Please give feedback when you have tested is. Thanks!

danrohtbart commented 5 years ago

Awesome, thanks! I should be able to test it over the weekend.

gertkjerslev commented 5 years ago

No problem. You can test with the virtual printer under "Serial Port" in OP, if don't want to "waste" a print on testing. :-) Looking forward to your feedback. Thanks.

danrohtbart commented 5 years ago

Brilliant! Is the Virtual Printer a plugin I need to add? It wasn't in the dropdown list.

On Tue, Feb 19, 2019 at 9:37 AM gfk76 notifications@github.com wrote:

No problem. You can test with the virtual printer under "Serial Port" in OP, if don't want to "waste" a print on testing. :-) Looking forward to your feedback. Thanks.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gfk76/OctoPrint-Nexmonotifier/issues/1#issuecomment-465153549, or mute the thread https://github.com/notifications/unsubscribe-auth/AYEZQDDSe0ELHtuQlQw1iUBtkg0Nr7jtks5vPAw9gaJpZM4bCAFc .

--

Dan Rohtbart Director, Engineering drohtbart@foursquare.com

gertkjerslev commented 5 years ago

It's a debug mode for octoprint http://docs.octoprint.org/en/master/development/virtual_printer.html

danrohtbart commented 5 years ago

Thanks! The new version works great. I was able to successfully send an SMS via Nexmo in the US.