gertqin / vuex-class-modules

Typescript class decorators for vuex modules
MIT License
194 stars 20 forks source link

Allow usage in node app without babel #47

Closed ftes closed 3 years ago

ftes commented 3 years ago

Observation

The sources are transpiled with a tsc module target of es2015.

Problem

This makes them unusable in a node app with only a typescript setup (no webpack or babel):

./node_modules/vuex-class-modules/lib/index.js:1
export { Action } from "./actions";
^^^^^^

SyntaxError: Unexpected token 'export'

Proposed solution

46 Transpile to commonjs modules in addition to es2015.

bodograumann commented 3 years ago

Now that the PR is merged, are this complete, @ftes ?

ftes commented 3 years ago

Yes, thanks! Using it in our project already :).

On Wed, Feb 24, 2021, 10:07 Bodo Graumann notifications@github.com wrote:

Now that the PR is merged, are this complete, @ftes https://github.com/ftes ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gertqin/vuex-class-modules/issues/47#issuecomment-784924466, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAT6LTGS5NAW4256LIN7WFTTAS6V5ANCNFSM4UDONEAQ .