search

gertvv / gemtc

GeMTC R package: model generation for network meta-analysis
GNU General Public License v3.0
44 stars 27 forks source link

Make nodesplitting compatible with data in tibbles #59

Closed riher closed 3 years ago

riher commented 4 years ago

Fixes https://github.com/gertvv/gemtc/issues/58 This does the trick for me. Tests (unit + regress) don't complain either.

gertvv commented 4 years ago

Thanks so much for the pull request! I agree this is a good idea, but I think I'd rather put the conversion right at the source in mtc.network, and apply it to all arguments that currently expect data frames. That way the documentation can be updated to signal it's compatible with types that can be coerced to data frames. If you're happy to do that, that'd be great. Otherwise I'll probably (eventually) get around to it myself.

riher commented 4 years ago

Good idea. I'll try to look into it.

gertvv commented 3 years ago

Closing as an alternative fix is on master.