gerwaric / acquisition

Stash and forum shop management for Path of Exile
GNU General Public License v3.0
18 stars 3 forks source link

Item categories have not been initialized (BREAKING CHANGE - 7/29) #47

Closed aiolos01 closed 3 months ago

aiolos01 commented 4 months ago

It worked the last time I run it. Now it just says that message in the log window and displays nothing.

gerwaric commented 4 months ago

The categories are initialized by downloading and parsing files from RePoE. The error you're getting could happen if the network is down or maybe if GitHub did not respond in time. If that's the case, this error might not happen if you try again later.

Specifically, these are the files acquisition tries to download:

I'm especially interested if those links work when you copy them into the browser, but you're still seeing this error. That could mean there is some kind of race condition, where acquisition needs to wait for those downloads before opening the main window.

(Aside: I was once trying to test acquisition on in-flight wifi, and the network lag was so terrible I disovered some other issues like this)

aiolos01 commented 4 months ago

If I get this error again I'll check and let you know. For the time being I installed the new version and it works. Not sure if the version change helped. Thanks for adding tab delete. Such a useful feature.

gerwaric commented 4 months ago

If it happens again, I've been thinking about bundling those files into acquisition so we aren't relying on downloading something from GitHub. That would solve the problem, too.

aiolos01 commented 4 months ago

I suppose this would be the best option since it doesn't rely on the existence of a github repository that belongs to someone else.

duarm commented 3 months ago

lvlvllvlvllvlvl broke acquisition with this change https://github.com/lvlvllvlvllvlvl/RePoE/commit/ad7952e6c2c05ec8a626fec2886e90ca01dffcdd, there are no more .min.json files, resulting in an error

gerwaric commented 3 months ago

Thank you for the heads up. I might be able to get a fix out today, if it's as simple as swapping to the un-minified versions.

Longer-term, I'd still like to bake these files into acquisition so it doesn't depend on network access and a remote repo to initialize. Maybe add the option to update these files manually, so that acquisition doesn't have to be rebuilt every time they change.

gerwaric commented 3 months ago

Let me know if this works for you now:

https://github.com/gerwaric/acquisition/releases/tag/v0.11.1

duarm commented 3 months ago

I'm actually on linux, instructions on how to build are unclear, I've been using the last release app image

gerwaric commented 3 months ago

Ok, if you give me a few minutes I will try to get the AppImage built and uploaded. Apologies for the confusing build instructions in the meantime.

Can I ask what distribution and version of Linux you are running?

duarm commented 3 months ago

I'm on archlinux, linux 6.10.2

gerwaric commented 3 months ago

I've uploaded an AppImage for Linux. Please let me know if it works.

The linux release are built on a Cinammon Mint 20 virtual machine. I'm not a linux developer (or any kind of developer), so it's been a bit of a trial and error process to figure things out. One tricky thing I've encountered is that acqusition needs SSL 3.x, but the app image creator won't include those libraries, so they still need to be installed locally on your system... I think.

duarm commented 3 months ago

It works now, thanks for fixing it so quickly

gerwaric commented 3 months ago

Fixed with https://github.com/gerwaric/acquisition/releases/tag/v0.11.1.1