gerwaric
commented
3 months ago EDIT: I just saw the email from GGG. Crap. I'm working on this now. I will leave the rest of this comment because it still covers my current understanding of the problem. I've also deleted affected installers.
You're the second person I'm aware of who was blocked by Cloudflare for this issue. (See https://github.com/gerwaric/acquisition/issues/50). I'm almost certain this was caused by a change I introduced in v0.11.1-alpha.12, which made it into the v0.11.1 release, and was not fixed until v0.11.1.1 (EDIT: the latest version is still bugged). See below for details. If I'm right about this, this bug was also the cause of https://github.com/gerwaric/acquisition/issues/51. I have removed the installers and added warnings to all the affected version so that nobody else can accidentally install these versions.
First, I'm sorry.
This bug, like you experienced first-hand, not only impacts acquisition, but it blocks people from using other third-party tool, and it blocks them from accessing the official website. I introduced this bug while trying to troubleshoot a mysterious crash that turned out to be unrelated, https://github.com/gerwaric/acquisition/issues/49.
If you want to know what was happening under the hood, here's a summary:
At startup, acquisition doesn't know the status of the API rate limit policies, so it makes special HEAD requests to check the status before making any API calls. These HEAD requests don't count against the rate limit policy, so they are "safe" in one sense. I've tried to be very cautious about things like this, because Acquisition was black-listed at the application level by GGG last year for violating rate limit policies. However, that caution backfired in this case.
The problem was two-fold.
First, acquisition was incorrectly rejecting replies to some of these HEAD requests. In alpha.12, I started strictly checking response codes for 200 OK, but some of them were coming back with 204, which acquisition should have accepted because 200-299 are all considered "success". This was my first mistake.
Second, once a HEAD reply was rejected, acquistion would immediately continue onto the next stash request. This triggered another HEAD request because acquistion was still trying to check the status of the rate limits. However, the reply to this second HEAD request would be incorrectly rejected just like the first. I should have blocked accquisition from sending requests after experiencing a failure. This was my second mistake.
With as many stash tabs as you and other have in Standard, this was causing enough requests to trigger Cloudflare's own rate limit policies. These are different from GGG's rate limit policies, and the Cloudflare policies are undocumented as far as I know, but several hundred or thousand HEAD requests in the span of a few seconds is enough to violate them.
I'm cautiously hopeful that this issue has been resolved with v0.11.1.1...
Honestly, this bug was due to my being a rookie c++ web software developer. When acquisition was black-listed for rate limit violations last year, I decided to teach myself enough to solve the problem. Since then, I've been learning more with each issue. My apologies again.
livejamie
Shadetorrent
This happened to me last week when we were troubleshooting #48
It happens only when I log on to Standard.
Today I logged onto my league account and it worked as expected, but I tried to log onto my Standard account and it showed 120+ errors, something about being unable to parse tabs and the program crashed.
I'm now banned for 24 hours again.
I can't provide any logs because I can't use my SESSID or OpenID to log on to the Path of Exile website.
I'll ask Novynn if they can provide any additional information to help troubleshoot. They said they would pass it along to you.