gerwaric / acquisition

Stash and forum shop management for Path of Exile
GNU General Public License v3.0
18 stars 3 forks source link

Mod filtering not working in v11 releases #57

Closed wallacrs closed 3 months ago

wallacrs commented 3 months ago

Switched to v11.2rc1 and found that after selecting a mod from the dropdown, my tab item list is not automatically filtered (as it used to in older versions). Filtering by socket count, armor, etc (selection above mod list) all work fine. I was previously using 10.3 but it seems to have stopped being able to connect to servers to download tab list (error just after opening) Don't get any errors showing in log.txt (default INFO logging). TRACE logging shows multiple instances of:

TRACE 2024-08-03T19:14:14.743 MainWindow::OnLayoutChanged() entered 
TRACE 2024-08-03T19:14:14.743 MainWindow::OnLayoutChange() nothing was selected

when making a selection in the mod list dropdown. Tried quite a few different mods, none seemed to trigger any filtering of item list. Can help with further info if needed to reproduce the issue. Thanks!

gerwaric commented 3 months ago

Thanks for the bug report. I'll take a look at it later this morning and get back to you.

gerwaric commented 3 months ago

I was able to reproduce this error, and I think this should fix it:

https://github.com/gerwaric/acquisition/releases/tag/v0.11.2-rc.2

Let me know if this works for you.

wallacrs commented 3 months ago

Hi. Thanks for the quick fix - however it seems the Windows .exe on Github has been built for RC1 rather than RC2 (the file size is also identical to the original RC1 release). Is it possible to please get a re-build of RC2 for Windows? [image: image.png]

On Sun, 4 Aug 2024 at 02:41, GERWARIC @.***> wrote:

I was able to reproduce this error, and I think this should fix it:

https://github.com/gerwaric/acquisition/releases/tag/v0.11.2-rc.2

Let me know if this works for you.

— Reply to this email directly, view it on GitHub https://github.com/gerwaric/acquisition/issues/57#issuecomment-2266740342, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHY67RNXE4M5URMZB7M5E3ZPTT3PAVCNFSM6AAAAABL5VWOEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRWG42DAMZUGI . You are receiving this because you authored the thread.Message ID: @.***>

gerwaric commented 3 months ago

Thanks for catching that. I just removed the RC1 installer and uploaded RC2, then confirmed it by downloaded and running the installer myself just to make sure :)

wallacrs commented 3 months ago

That's got it, filtering now working again on mods. Thanks for the quick update, and for all the work you've put in to keep Acquisition up and running! I play SSF but Acq is super-handy for me to find all the random gear I find and keep stashed away in case it might be useful on a different character. Cheers!

gerwaric commented 3 months ago

Thanks and good luck!