gesinn-it-pub / mediawiki-extensions-PageForms

Fork of MediaWiki extension PageForms that aims to simplify contribution through hosting on GitHub instead of Gerrit, improved quality through better test coverage (to be done) and continuous integration.
Other
1 stars 4 forks source link

OOUI image upload dialog gets covered by chameleon navbar #29

Open krabina opened 1 year ago

krabina commented 1 year ago

When you click on the image icon in WikiEditor on a regular page and then on "upload", a OOUI upload dialog appreas that is working fine also with chameleon skin present: image

However, If I try the same thing on the same wiki, but run this from within a pageforms free text field, the header of the upload dialog gets covered by the chameleon navbar: image

Took me a while to figure this out!

krabina commented 1 year ago

as a workaround, putting the following in MediaWiki:Common.css works:

.oo-ui-windowManager-modal > .oo-ui-dialog {
    z-index: 1020;
}

1020 is the smallest number that works.

However, this is not the desired solution, because I don't know what other effects this has, and I have to think about this all the time. So the underlying problem in PF should be investigated.

krabina commented 1 year ago

Current setup:

Software | Version -- | -- MediaWiki | 1.35.8 PHP | 7.4.3-4ubuntu2.18 (fpm-fcgi) MariaDB | 10.3.38-MariaDB-0ubuntu0.20.04.1 ICU | 66.1 Elasticsearch | 6.8.23 LuaSandbox | 4.0.2 Lua | 5.1.5 Chameleon | 4.1.0 Page Forms | 5.3.4.4 (301aad4) 12:01, 13. Sep. 2022
krabina commented 1 year ago

Vor the visual editor upload dialog (when you paste an image inside the free text field that has VE enabled, you have to set

.ve-ui-overlay-global {
    z-index: 1020;
}