search

gesinn-it-pub / mediawiki-extensions-PageForms

Fork of MediaWiki extension PageForms that aims to simplify contribution through hosting on GitHub instead of Gerrit, improved quality through better test coverage (to be done) and continuous integration.
Other
1 stars 4 forks source link

Use of SkinTemplateNavigation hook (used in PFFormEditAction::displayTab) was deprecated in MediaWiki 1.39 #44

Closed krabina closed 4 months ago

krabina commented 1 year ago

When using the latest version 5.3.4.6 (3017e9b) on MW 1.39, the following warnings show

Deprecated
: Use of SkinTemplateNavigation hook (used in PFFormEditAction::displayTab) was deprecated in MediaWiki 1.39. [Called from MediaWiki\HookContainer\HookContainer::run in /home/knowledge/test/includes/HookContainer/HookContainer.php at line 137] in
/home/knowledge/test/includes/debug/MWDebug.php
on line
381

Deprecated
: Use of SkinTemplateNavigation hook (used in PFHelperFormAction::displayTab) was deprecated in MediaWiki 1.39. [Called from MediaWiki\HookContainer\HookContainer::run in /home/knowledge/test/includes/HookContainer/HookContainer.php at line 137] in
/home/knowledge/test/includes/debug/MWDebug.php
on line
381
krabina commented 1 year ago
MediaWiki 1.39.4
PHP 8.0.27 (litespeed)
gesinn-it-ilm commented 4 months ago

Replacement for 'SkinTemplateNavigation' in MW 1.39 is 'SkinTemplateNavigation::Universal'.

That change has been introduced 8 months ago inside extension.json. (7e3acf0)

After running make ci and checking deprecated warnings for 1.39, deprecared warnings from above regarding SkinTemplateNavigation hook are fixed.

extension.json: Screenshot 2024-06-14 114001