fix issue 53 (Combobox shows 2 dropdowns with multi-instance template)

[thomas-topway-it]

fixes https://github.com/gesinn-it-pub/mediawiki-extensions-PageForms/issues/53 (Combobox shows 2 dropdowns with multi-instance template)

although there are other solutions, like to add .not('.pfComboBox .oo-ui-inputWidget-input') to the jQuery selector, the proposed solution is more general and prevents similar issues for other form inputs

[gesinn-it-gea]

Thanks for investigating!

[thomas-topway-it]

I see there are some errors on tests, they shouldn't be related to the pull request, however, since there aren't PHP edits

[gesinn-it-gea]

https://github.com/gesinn-it-pub/mediawiki-extensions-PageForms/actions/runs/7420421934/job/20191774931?pr=55#step:5:1750

[thomas-topway-it]

is it related to the edit ?

[thomas-topway-it]

ah, I see

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bff14a0) 11.68% compared to head (bce66c3) 11.68%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #55 +/- ## ========================================= Coverage 11.68% 11.68% Complexity 3589 3589 ========================================= Files 78 78 Lines 11552 11552 ========================================= Hits 1350 1350 Misses 10202 10202 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[gesinn-it-gea]

After this change, on a page with existing instances, instances can not be added or removed using the "instanceAddAbove" / "instanceRemove" buttons. No JS errors. To reproduce, create a page, add instances, save, edit again, try to remove an existing instance.

[krabina]

Yes, I can also reproduce this. You can add other instances, there the "add above" button works, but with existing values, you cannot add someting above.

[thomas-topway-it]

I did an edit. I will double check tomorrow.

[krabina]

Thank you. It is working for me now.

[gesinn-it-gea]

Confirmed working. @krabina is your issue mentioned in #53 also fixed now?

[krabina]

yes!