Closed samwilson closed 1 year ago
If you hide whitespace you can get a better idea of the actual changes here. Mostly it's line endings and indents.
I wasn't sure how this should be added to the Makefile (and so CI).
make ci
at the end calls composer test
:
https://github.com/gesinn-it/QRLite/blob/master/Makefile#L36 → https://github.com/gesinn-it/QRLite/blob/master/composer.json#L26
...and GitHub Actions CI calls make ci
:
https://github.com/gesinn-it/QRLite/blob/master/.github/workflows/ci.yml#L35
I've added a separate npm-test
target (is that what they're called? I'm afraid it's probably been ten years since I touched a Makefile!).
Where should the npm ci
command be added though? And does the docker image even include npm?
I'll have a look...
The Docker image comes with npm 7.5.2. Just add npm ci && \
to the Dockerfile before ~L8 (composer update)
. Maybe package-lock.json
needs to be updated.
Here's a more complex example of such a Dockerfile: https://github.com/SemanticMediaWiki/SemanticDrilldown/blob/master/Dockerfile
Okay great, I think I've sorted it all out now. See what you think.
Many thanks for your contribution!
This follows the MediaWiki conventions for these sorts of tests.