search

gesior / Gesior2012

Gesior 2012 - Account Maker [website] for OTSes, account maker you can find in BRANCHES. Select 'branch'.
75 stars 84 forks source link

Clean code in install #21

Open luanluciano93 opened 9 years ago

luanluciano93 commented 9 years ago

Hello Gesior could simplify this code: https://github.com/gesior/Gesior2012/blob/TFS-1.0/install.php#L18-L52

that is why: include_once('./system/load.init.php');

https://github.com/gesior/Gesior2012/blob/TFS-1.0/install.php#L145-L179 that is why: include_once('./system/load.database.php');

among other things ..

gesior commented 9 years ago

If someone got a minute:

  1. change it
  2. test if installer still works
  3. make pull request

Refactoring in Gesior is around.. zero, so these lines is not a big problem.