search

gesistsa / adaR

:computer: wrapper for ada-url a WHATWG-compliant and fast URL parser written in modern C++
https://gesistsa.github.io/adaR/
Other
26 stars 2 forks source link

fix #44 #45

Closed schochastics closed 1 year ago

schochastics commented 1 year ago

@chainsawriot I think I am catching all corner cases now for public_suffix but please have a look.

schochastics commented 1 year ago

This in data-raw/psl.R

rev_raw_list <- sapply(paste0(".", raw_list), url_reverse)

Fixes the current errors, but introduces the "kobe issues" again, i.e.:

public_suffix("http://kobe.jp")
jp

I wonder if it is even possible to effectively deal with all corner cases