gesistsa / adaR

:computer: wrapper for ada-url a WHATWG-compliant and fast URL parser written in modern C++
https://gesistsa.github.io/adaR/
Other
26 stars 2 forks source link

Fix leak ref #49 #52

Closed chainsawriot closed 11 months ago

chainsawriot commented 11 months ago

valgrind indicates no leak anymore; but we have the remaining issue of charsub with "Invalid read of size 1" fixed

chainsawriot commented 11 months ago

@schochastics The memory leak being fixed improves the performance. So, there is no performance impact actually. You can decide to squash or just merge.