search

gesistsa / adaR

:computer: wrapper for ada-url a WHATWG-compliant and fast URL parser written in modern C++
https://gesistsa.github.io/adaR/
Other
26 stars 2 forks source link

changed href computation (fix #66) #68

Closed schochastics closed 9 months ago

schochastics commented 9 months ago

@chainsawriot can I get your opinion again? What is your take on the failing test?

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test-get.R:3:5'): all get functions work ──────────────────────────
ada_get_href(url) (`actual`) not equal to "https://user_1:password_1@example.org:8080/api?q=1#frag" (`expected`).

`actual`:   "https://user_1:password_1@example.org:8080/dir/../api?q=1#frag"
`expected`: "https://user_1:password_1@example.org:8080/api?q=1#frag"
chainsawriot commented 9 months ago

@schochastics I think we will need to do it with the silent convert approach (sorry that I forgot the crazy case of ".../dir/"). I will send a PR later.

schochastics commented 9 months ago

thanks, urls keep being "interesting"