gesistsa / rang

🐶 (Re)constructing R computational environments
https://gesistsa.github.io/rang/
GNU General Public License v3.0
77 stars 3 forks source link

UnRipley the package #149

Closed chainsawriot closed 1 year ago

chainsawriot commented 1 year ago

Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_rang.html.

Please correct before 2023-08-11 to safely retain your package on CRAN.

The CRAN Team

chainsawriot commented 1 year ago

The cause is that this test is not wrapped with skip_on_cran()

https://github.com/chainsawriot/rang/blob/3c236aff92a9ec097c7b0441b8877af990198f3f/tests/testthat/test_resolve.R#L148-L153

It can be easily plugged.

But the other problem is that resolve() is surprisingly nondeterministic in the test environment.

chainsawriot commented 1 year ago

TODO

chainsawriot commented 1 year ago

52fe7d88857c0e3ca79a3207027f4e6bf4405c8b