search

gesistsa / rio

🐟 A Swiss-Army Knife for Data I/O
http://gesistsa.github.io/rio/
599 stars 76 forks source link

Compression infrastructure is insufficiently tested #354

Closed chainsawriot closed 4 months ago

chainsawriot commented 12 months ago

https://github.com/gesistsa/rio/blob/81c04236dab444aaea9b9ca953f48ccc33ba4d88/tests/testthat/test_compress.R#L3-L27

https://github.com/gesistsa/rio/blob/81c04236dab444aaea9b9ca953f48ccc33ba4d88/R/compression.R#L18

It only tests zip and tar. gzip (implemented in #123 ) is untested.

https://github.com/gesistsa/rio/blob/81c04236dab444aaea9b9ca953f48ccc33ba4d88/R/import.R#L112-L116

So do formats such as xz and bzip2.

chainsawriot commented 12 months ago

TODO

chainsawriot commented 4 months ago

After #380, it is pretty easy to implement this.

https://github.com/gesistsa/rio/blob/479a765a37b6cfad323778660121c8deaf0c874f/tests/testthat/test_compress.R#L11-L21