search

gesistsa / rio

🐟 A Swiss-Army Knife for Data I/O
http://gesistsa.github.io/rio/
594 stars 77 forks source link

Adds trust parameter with deprecation for default #409

Closed jsonbecker closed 2 months ago

jsonbecker commented 2 months ago

This is an attempt to address #406 by adding a new parameter trust set to TRUE by default with a deprecation warning that this will flip to FALSE in 2.0.0.

chainsawriot commented 2 months ago

@jsonbecker Added my several comments. Please consider them. Thank you very much!

jsonbecker commented 2 months ago

@jsonbecker Added my several comments. Please consider them. Thank you very much!

These are great suggestions I'll probably work on today. I mostly wanted to get up a proof of the idea after discussing it in the issue. But with the improvements you proposed, I feel pretty good about this as an idea.

chainsawriot commented 2 months ago

@jsonbecker I will merge this now. But I will also make some slight adjustments (mostly on the documentation in the import() function, perhaps also the vignettes). I will request your review later.