Closed GoogleCodeExporter closed 8 years ago
Looks good, can you put this patch up as an item on codereview.appspot.com?
Original comment by joe.gregorio@gmail.com
on 9 Dec 2009 at 2:14
Done, though this seems like a lot of work given you could just have hg
import'ed my
patch (which also gets the credit right). Is this something new you're trying?
http://codereview.appspot.com/168042
Original comment by djc.ochtman
on 9 Dec 2009 at 2:23
Yes, I want all patches to go through codereview.appspot.com, it speeds up my
ability
to give feedback on patches. Yours was obviously on the small side for that.
Now
committed.
Original comment by joe.gregorio@gmail.com
on 9 Dec 2009 at 2:38
Okay, that makes sense, then. Thanks for the quick review!
Original comment by djc.ochtman
on 9 Dec 2009 at 2:39
Original issue reported on code.google.com by
djc.ochtman
on 8 Dec 2009 at 8:45