gessnerfl / fake-smtp-server

A simple SMTP Server for Testing purposes. Emails are stored in an in-memory database and rendered in a Web UI
Apache License 2.0
437 stars 90 forks source link

default-page-size does not (seem to) have any effect anymore #201

Closed Slartibartfast27 closed 1 year ago

Slartibartfast27 commented 1 year ago

Setting parameter default-page-size does not seem to have any effect anymore in version 2.0.3. Only 10 emails are shown by default.

  data:
    web:
      pageable:
        size-parameter: size
        page-parameter: page
        default-page-size: 100
        one-indexed-parameters: false
        max-page-size: 1000

Also failed to inject the page size with size=100 in the url like this: http://fakesmtp/?page=2&size=100 Still only 10 emails were shown.

Remark: This worked very well before in versions 1.x.x

gessnerfl commented 1 year ago

Due to technical reasons, max-page-size will not be supported any longer on the UI. It still has effect on the API. Changing page size will be added to the UI which will allow switching between different page sizes

gessnerfl commented 1 year ago

Changing page size is now available with version 2.1.2

Slartibartfast27 commented 1 year ago

Thank you @gessnerfl very much for adding this very useful feature to the UI: grafik This already helps very much 😀

May I ask two more questions, as I did not manage to make everything work again:

Question 1: Default page size I set it to 100 in the application.yaml as follows:

# taken from https://github.com/gessnerfl/fake-smtp-server/blob/master/src/main/resources/application.yaml

spring:
  data:
    web:
      pageable:
        size-parameter: size
        page-parameter: page
        # https://github.com/gessnerfl/fake-smtp-server/issues/201
        default-page-size: 100
        one-indexed-parameters: false
        max-page-size: 1000

Nevertheless the UI always starts with 10 when invoked without parameters, e.g. http://fakesmtp Is there a way to see 100 emails when starting up?

Question 2: Max page size I set it to 1000 in the application.yaml as shown above. When trying to use 1000 by manipulating the URL as follows: http://fakesmtp/?page=0&pageSize=1000 still only 100 emails are shown:

grafik

Is there a way to see 1000 emails if required and configured as above?

gessnerfl commented 1 year ago

@Slartibartfast27

The spring data max-page-size parameter is not supported in the UI for technical reasons. The same applies for the maximum supported page size. In the UI there is a technical limitation of 100 entries per page. I'm looking for alternatives but cannot promise that this will change soon.