gestalt-config / gestalt

A Java configuration library
Apache License 2.0
77 stars 2 forks source link

Feat/self destruct nodes #198

Closed credmond-git closed 2 months ago

credmond-git commented 2 months ago

feat: move ConfigNode processing to a new ConfigNodeProcessorService. Order Config Node Processors. Add a service interface for ObservationService and ResultProcessorService, so users can implement their own if they wish. This is a Breaking change for the GestaltBuilder. It should impact very few people as i dont really expect many people to provide their own ObservationService, or ResultProcessorService and if they do it is an easy change. Checks if the node is a leaf and a temporary secret. if it is, replaces the leaf node with a TemporaryLeafNode that can only be accessed a limited number of times. After the limited number of times, the value is released to be GC'ed. https://github.com/gestalt-config/gestalt/issues/197

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 93.00412% with 17 lines in your changes missing coverage. Please review.

Project coverage is 90.69%. Comparing base (3995c53) to head (099baa7).

Files Patch % Lines
.../github/gestalt/config/builder/GestaltBuilder.java 85.71% 4 Missing and 3 partials :warning:
...in/java/org/github/gestalt/config/GestaltCore.java 70.00% 0 Missing and 6 partials :warning:
...n/java/org/github/gestalt/config/GestaltCache.java 82.35% 0 Missing and 3 partials :warning:
...t/config/security/temporary/TemporaryLeafNode.java 96.15% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #198 +/- ## ========================================== + Coverage 90.60% 90.69% +0.09% ========================================== Files 230 236 +6 Lines 6416 6546 +130 Branches 730 737 +7 ========================================== + Hits 5813 5937 +124 - Misses 375 379 +4 - Partials 228 230 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.4% Duplication on New Code

See analysis details on SonarCloud