search

get-alex / alex

Catch insensitive, inconsiderate writing
https://alexjs.com
MIT License
4.82k stars 207 forks source link

Add a GitHub corner to the website #200

Closed wooorm closed 6 years ago

wooorm commented 6 years ago

Subject of the issue

There’s one small link on the website, to GitHub, but a GitHub Corner would be clear.

Steps to reproduce

Go to the website

Expected behaviour

There should be a clearly visible way to go to GitHub.

Actual behaviour

There is no such reference 😢

Redarcher9 commented 6 years ago

Hi there,I'm new to open-source community.Can I work on this issue?

wooorm commented 6 years ago

Hi @Redarcher9! Yes, please! I’d suggest waiting till tomorrow to participate in hacktoberfest though! 🎃

Redarcher9 commented 6 years ago

Thankyou @wooorm !I am familiar with javascript but haven't used Node.js before.Can you help me figure out what things do i need to learn before contributing to this issue?

wooorm commented 6 years ago

If you’ve installed Node already, you should be fine following the contributing guides.

Note that the website is on the website branch, and the file you‘re looking for to add the corner is src/index.html. If you change that, and run npm test, all files are minified and built to the dest directory. If that looks file, you’re done! 👍

meetcric commented 6 years ago

Hi there,Can i work on this issue?

wooorm commented 6 years ago

@meetcric Let’s give @Redarcher9 a shot first!

meetcric commented 6 years ago

Okey..is there any other issue I can work on?

wooorm commented 6 years ago

@meetcric Yup, https://github.com/get-alex/alex/issues/199 I think!

meetcric commented 6 years ago

@wooorm think @cunhazera is working in #199. should I start to work on that issue?

wooorm commented 6 years ago

I believe he misplaced his comment, so I think you're free to work on that one!

cunhazera commented 6 years ago

@meetcric no, I'm not. That's all yours :)

meetcric commented 6 years ago

@wooorm can u explain this issue in details please?

wooorm commented 6 years ago

@meetcric Could you discuss that problem on its own issue (GH-199)?

TJScalzo commented 6 years ago

Personally, I think the GitHub corner as it's styled right now doesn't fit the style of the site. I feel like it would look better styled like this with colors already used on the landing page.

Should I make a pull request with this change?

svcastaneda commented 6 years ago

@TJScalzo I don't think that idea complies with GitHub's logo usage guide mostly because of the animation and possibly the usage of a purple background instead of a white or dark grey color

TJScalzo commented 6 years ago

@svcastaneda Does that mean the current GitHub corner is breaking their branding standards? The person who designed the corner seems to show it being used in a variety of color combinations on his site. If the animated corner goes against GitHub’s logo rules, should we be using it at all?

wooorm commented 6 years ago

Whoops! I forgot to close this issue! Here, let me do that.

I totally agree that it could be styled better though, @TJScalzo, I’d appreciate a PR for that.

@svcastaneda thanks for chiming in! Hmm, I hadn’t thought about that. The corners are used on a lot of websites, the animation is always in there. I guess most corners thus ignore the “Change the colors, dimensions or add your own text/images” rule. Are you suggesting we remove the corner? 🤔