search

get-alex / alex

Catch insensitive, inconsiderate writing
https://alexjs.com
MIT License
4.81k stars 207 forks source link

Fix typo #323

Closed jneidel closed 3 years ago

jneidel commented 3 years ago

religion inconsiderate -> religiously inconsiderate

wooorm commented 3 years ago

Hmm I’m not sure that means the same thing? Maybe it can be pulled into the preceding, or dropped, or reworded in another way?

jneidel commented 3 years ago

I’m not sure that means the same thing

You are trying to say that wordings, which are offensive or inconsiderate toward religion, are found in text. Right?

"[..] alex helps you find [..] religiously inconsiderate [..] phrasing in text."

religiously inconsiderate, or inconsiderate as it relates to religion. "religiously" as an adjective closer describes the "inconsiderate phrasing" as concerning religion.

Maybe it can be pulled into the preceding, or dropped, or reworded in another way?

You can reword it if you want, I'm just fixing your error. "religion inconsiderate" is just an erroneous wording.

wooorm commented 3 years ago

I'm just fixing your error.

What do you mean by this? It feels like a personal attack. I don’t see why that’s needed. I’m not sure why you’re taking such a “take it or leave it” approach to open source issues.

What I’m commenting on is that the word religiously, they way you use it, reads to me more as an alternative meaning of the word. Less about religion, more about devout, obsessive, focussed, or very. It reads as very inconsiderate to me. I’m open to improving the problem you found but I don’t see your current patch as doing so. One alternative is inconsiderate to religion. Note though that I’m not a native English speaker.

jneidel commented 3 years ago

Less about religion, more about obsessive, focussed, or very.

This is not supported by the definition of the word. Though I know what you're getting at: "He religiously follows baseball." is not about about religion but being obsessed with baseball by invoking the comparison to religions fervor. Still has a religious conotation.

Less about religion, more about devout

It has expressly religious connotations.

Note though that I’m not a native English speaker.

Me neither.

I'm just fixing your error.

What do you mean by this? It feels like a personal attack. I don’t see why that’s needed.

It is not meant as a personal attack. I spotted an error and opened a PR (in my mind) fixing it.

I’m not sure why you’re taking such a "take it or leave it” approach to open source issues.

I fix typos as a curtsy, but that does not mean that I want to partake in the project. I'm not interested in rewording or endless discussion. I pointed out an error and provided a (again, in my mind) perfectly fine solution (that I can support with the dictionary of my choice). At this point I've done my civic duty.

You can call it what you want, but you could reflect on the amount of effort that went into our respective answers before judging.

At this point I will unsubscribe from this PR, handle it as you please.