search

get-convex / convex-auth

Library for built-in auth
https://labs.convex.dev/auth
39 stars 6 forks source link

Setup script should detect and run the project's package manager #26

Closed itsMapleLeaf closed 1 month ago

itsMapleLeaf commented 1 month ago

Currently, when running the auth setup tool in a Bun project, it tries to use npm:

image

(This screenshot is only to illustrate running npm, I only got an error here because of my bad peer deps)

xixixao commented 1 month ago

@itsMapleLeaf can you say more about why this is a problem for you?

itsMapleLeaf commented 1 month ago

Sure, and I guess this isn't actually Bun-specific.

Other generators nowadays detect which package manager your project uses and runs that. Otherwise, you have to wait for a (potentially loooong) install process via npm (which might even fail due to strict peers, as seen above) before having to reinstall your deps again.

xixixao commented 1 month ago

@itsMapleLeaf that command doesn't install anything, so I don't think this is an issue right now. This would only be an issue if you only had bunx and not npx at all, but I think that's unlikely.

itsMapleLeaf commented 1 month ago

Huh, yeah it just runs npx and not npm 🫠 I guess I'll just close this then, since npx failing in this case is a local issue.