sshader
commented
1 month ago I believe this is just the logging that's confusing -- it's logging that the server function threw an error, but the error is still catchable on the client (so it's an uncaught error from the perspective of the server, but not necessarily from the perspective of the client, even though this message will appear in client logs).
The ConvexError is catchable on the client (here's the sample code I was testing with)
onClick={() =>
void signIn("simple-auth").catch((e) => {
if (e instanceof ConvexError) {
window.alert(`Convex Error!\nData: ${JSON.stringify(e.data)}`);
} else {
console.error("#### caught unknown error", e);
throw e;
}
})
}The Convex Auth library could be wrapping all non-ConvexErrors thrown during authorize in an error with a prettier message (like "Authorization failed" as opposed to just "Server Error"), but throwing custom errors from authorize that the client can handle should be working as intended.
doublemarked
pdesign
labigalini
Overview
Exceptions (including ConvexError) are unhandled when thrown from a ConvexCredentials.authorize() method.
Setup
Outcome
Expected outcome
At minimum, the exception should be caught by Convex. But ideally, throwing an exception from authorize() should bubble up to the client side so that the client can handle the error. We should be able to use exceptions or some other mechanism to communicate failure conditions to the client during authorize() in order to better control the authorization process.