search

get-iplayer / get_iplayer

A utility for downloading TV and radio programmes from BBC iPlayer and BBC Sounds
https://github.com/get-iplayer/get_iplayer/wiki
GNU General Public License v3.0
2.15k stars 233 forks source link

Adds thumbsrc option to prefer episode thumbnails #331

Closed miloush closed 7 years ago

miloush commented 7 years ago

Addresses https://squarepenguin.co.uk/forums/thread-1276.html with --thumbsrc=episode, otherwise defaults to the current behavior.

Argument for including: Radio episodes often have useful and selected thumbnails that are addressed in the program description, see e.g. http://www.bbc.co.uk/programmes/b006qt55/episodes/player or http://www.bbc.co.uk/programmes/b0738jc2/episodes/player. All episodes of the latter series for example, such as http://www.bbc.co.uk/programmes/p058gh24, describe the image, e.g. "Image: Cadets during a National Conference rally at Lal Chowk, Srinagar 1944 Credit: India Picture". Having hundreds of episodes with the same unrelated series thumbnail is not very helpful.

Tested on Windows only, using Strawberry Perl.

dinkypumpkin commented 7 years ago

Thanks for the PR. However, I'm planning to implement thumbnail changes with the same effect, but in a different way. It will be in the next release.

miloush commented 7 years ago

Glad to hear that, your response on the forums didn't give much hope. Thanks!

dinkypumpkin commented 7 years ago

Since you accepted the challenge and submitted a pull request, I thought your changes, or something similar, should go in. It's just that in this case I decided to revert to the old behaviour, where the episode image is used by default.