get-iplayer / get_iplayer

A utility for downloading TV and radio programmes from BBC iPlayer and BBC Sounds
https://github.com/get-iplayer/get_iplayer/wiki
GNU General Public License v3.0
2.12k stars 230 forks source link

Metadata is always downloaded and written to file, even without --overwrite #415

Closed JohnVeness closed 2 years ago

JohnVeness commented 2 years ago

Do not file a bug report if you are using get_iplayer outside the UK. If you do, your report will be ignored.

Do not file a bug report if you are using get_iplayer with a VPN or proxy from any location, including the UK. If you do, your report will be ignored.

Search the repository (search field at top left) to see if a report already exists for the bug in the issue tracker. Do not create a duplicate report. Duplicate reports will be ignored.

Review recent open and closed entries in the issue tracker to see if a report already exists for the bug. Do not create a duplicate report. Duplicate reports will be ignored.

Ensure that you are using get_iplayer 3.30 or higher. If not, your report will be ignored.

Identify the operating system and version where get_iplayer demonstrates the bug

Ubuntu 22.04

Provide a clear and concise description of the bug. Do not paste get_iplayer output or screenshots into the field below. If you do, your report will be ignored.

I use commands like the below to download metadata, credits, and thumbnails only, for certain search terms.

For credits and thumbnail files, the files are not downloaded if they are already present, unless --overwrite is added (this is working correctly). But the metadata is always downloaded and written, even if there is already a file present (this is, I argue, a bug).

I think metadata files should act more like credits and thumbnails (and presumably also how subtitles and the main media files act) and were only written to disc if there is not a file of the same name already there, unless --overwrite is added.

Provide the PID or URL of the programme you are attempting to download, if applicable. Provide the PID or URL for only one programme.

No response

Provide the complete get_iplayer command line that demonstrates the bug. Do not truncate or excerpt the command. If you do, your report will be ignored. If you are using the Web PVR, list the steps necessary to reproduce the bug, in as much detail as possible.

get-iplayer "celebrity supply teacher" --get --credits-only --metadata=json --metadata-only --thumbnail-only --future --refresh-future

Drag the log file into the field below to create an attachment. The log file must be added as an attachment. Do not paste its contents into the field below. If you do, your report will be ignored. You may enter a URL linking to your log file on a pastebin site. If the bug prevents get_iplayer from running, enter "N/A" in the field below. If you enter any other text in the field below, your report will be ignored.

log.txt

If you are using the Web PVR, provide your web browser name and version. This information typically can be found from the application menu via Chrome/Firefox/Safari->About... (macOS) or Help->About... (Linux/Windows)

No response