get-iplayer / get_iplayer

A utility for downloading TV and radio programmes from BBC iPlayer and BBC Sounds
https://github.com/get-iplayer/get_iplayer/wiki
GNU General Public License v3.0
2.13k stars 229 forks source link

thumbnails domain has changed from bcci.co.uk to bbc.co.uk #440

Closed labeneator closed 11 months ago

labeneator commented 11 months ago

Do not file a bug report if you are using get_iplayer outside the UK. If you do, your report will be ignored.

Do not file a bug report if you are using get_iplayer with a VPN or proxy from any location, including the UK. If you do, your report will be ignored.

Search the repository (search field at top left) to see if a report already exists for the bug in the issue tracker. Do not create a duplicate report. Duplicate reports will be ignored.

Review recent open and closed entries in the issue tracker to see if a report already exists for the bug. Do not create a duplicate report. Duplicate reports will be ignored.

Ensure that you are using get_iplayer 3.31 or higher. If not, your report will be ignored.

Identify the operating system and version where get_iplayer demonstrates the bug

MacOS 13.5.2 (22G91)

Provide a clear and concise description of the bug. Do not paste get_iplayer output or screenshots into the field below. If you do, your report will be ignored.

The link for a program thumbnails seems to have changed. For example, I get the following error

WARNING: Failed to download URL (1/3): https://ichef.bbci.co.uk/images/ic/1920x1080/p074rc35.jpg
WARNING: Response: 500 Can't connect to ichef.bbci.co.uk:443 (SSL connect attempt failed error:0A000126:SSL routines::unexpected eof while reading)
WARNING: Ignore this warning if programme download is successful

Curl for the url shows that the link isn't correct

 ❯ curl -vL https://ichef.bbci.co.uk/images/ic/1920x1080/p0742ttl.jpg                                                                                                                                                                               [21:53:29]
*   Trying 10.35.53.11:443...
* Connected to ichef.bbci.co.uk (10.35.53.11) port 443 (#0)
* ALPN: offers h2,http/1.1
* (304) (OUT), TLS handshake, Client hello (1):
*  CAfile: /etc/ssl/cert.pem
*  CApath: none
* LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to ichef.bbci.co.uk:443
* Closing connection 0
curl: (35) LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to ichef.bbci.co.uk:443

Playing around with the url shows that the thumbnail can be served from bbc.co.uk not bbci.co.uk

 ❯ curl -vL https://ichef.bbc.co.uk/images/ic/1920x1080/p0742ttl.jpg                                                                                                                                                                                [21:53:48]
*   Trying 104.72.154.141:443...
* Connected to ichef.bbc.co.uk (104.72.154.141) port 443 (#0)
* ALPN: offers h2,http/1.1
* (304) (OUT), TLS handshake, Client hello (1):
*  CAfile: /etc/ssl/cert.pem
*  CApath: none
* (304) (IN), TLS handshake, Server hello (2):
* (304) (IN), TLS handshake, Unknown (8):
* (304) (IN), TLS handshake, Certificate (11):
* (304) (IN), TLS handshake, CERT verify (15):
* (304) (IN), TLS handshake, Finished (20):
* (304) (OUT), TLS handshake, Finished (20):
* SSL connection using TLSv1.3 / AEAD-CHACHA20-POLY1305-SHA256
* ALPN: server accepted h2
* Server certificate:
*  subject: C=GB; ST=London; L=London; O=BRITISH BROADCASTING CORPORATION; CN=www.bbc.co.uk
*  start date: Oct 17 05:51:02 2022 GMT
*  expire date: Nov 18 05:51:01 2023 GMT
*  subjectAltName: host "ichef.bbc.co.uk" matched cert's "ichef.bbc.co.uk"
*  issuer: C=BE; O=GlobalSign nv-sa; CN=GlobalSign RSA OV SSL CA 2018
*  SSL certificate verify ok.
* using HTTP/2
* h2 [:method: GET]
* h2 [:scheme: https]
* h2 [:authority: ichef.bbc.co.uk]
* h2 [:path: /images/ic/1920x1080/p0742ttl.jpg]
* h2 [user-agent: curl/8.1.2]
* h2 [accept: */*]
* Using Stream ID: 1 (easy handle 0x142011400)
> GET /images/ic/1920x1080/p0742ttl.jpg HTTP/2
> Host: ichef.bbc.co.uk
> User-Agent: curl/8.1.2
> Accept: */*
>
< HTTP/2 200
< server: AmazonS3
< last-modified: Wed, 20 Mar 2019 14:45:44 GMT
< etag: "a59548b24f9e5c612d1d855be9c3f3e7"
< accept-ranges: bytes
< content-type: image/jpeg
< expires: Fri, 29 Sep 2023 18:53:49 GMT
< content-length: 472410
< cache-control: max-age=86400
< date: Thu, 28 Sep 2023 18:53:50 GMT
< timing-allow-origin: https://www.bbc.co.uk, https://www.bbc.com
< access-control-allow-headers: *
< access-control-allow-methods: HEAD,GET
< access-control-allow-credentials: false
< access-control-max-age: 300
< access-control-allow-origin: *
<
Warning: Binary output can mess up your terminal. Use "--output -" to tell
Warning: curl to output it to your terminal anyway, or consider "--output
Warning: <FILE>" to save to a file.
* Failure writing output to destination
* Connection #0 to host ichef.bbc.co.uk left intact

Provide the PID or URL of the programme you are attempting to download, if applicable. Provide the PID or URL for only one programme.

p071bjr7

Provide the complete get_iplayer command line that demonstrates the bug. Do not truncate or excerpt the command. If you do, your report will be ignored. If you are using the Web PVR, list the steps necessary to reproduce the bug, in as much detail as possible.

❯ get_iplayer --subtitles --tv-quality=sd --pid-recursive --pid=b04vs4r9

Drag your verbose log file into the field below to create an attachment. Your verbose log file must be added as an attachment. Do not paste its contents into the field below. If you do, your report will be ignored. You may enter a URL linking to your verbose log file on a pastebin site. If the bug prevents get_iplayer from running, enter "N/A" in the field below. If you enter any other text in the field below, your report will be ignored.

bbc.log

If you are using the Web PVR, provide your web browser name and version. This information typically can be found from the application menu via Chrome/Firefox/Safari->About... (macOS) or Help->About... (Linux/Windows)

No response