get-pytube / pytube3

A lightweight, dependency-free Python 3 library (and command-line utility) for downloading YouTube Videos.
https://pytube3.readthedocs.io
Other
178 stars 55 forks source link

Fixed cipher error #105

Closed rshigemura closed 2 months ago

rshigemura commented 3 years ago

This PR fix problems with some videos available on YouTube. Please verify.

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 2.12 ⭐ 2.12 ⭐ 0.00
Method Length 42.47 ⭐ 42.47 ⭐ 0.00
Working memory 6.88 🙂 6.88 🙂 0.00
Quality 84.19% 84.19% 0.00%
Other metrics Before After Change
Lines 287 287 0
Changed files Quality Before Quality After Quality Change
pytube/extract.py 84.19% ⭐ 84.19% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pytube/extract.py apply_descrambler 5 ⭐ 210 ⛔ 20 ⛔ 40.44% 😞 Try splitting into smaller methods. Extract out complex expressions
pytube/extract.py apply_signature 11 🙂 111 🙂 14 😞 50.30% 🙂 Extract out complex expressions
pytube/extract.py PytubeHTMLParser.handle_starttag 7 ⭐ 31 ⭐ 10 😞 72.68% 🙂 Extract out complex expressions
pytube/extract.py video_info_url 0 32 ⭐ 12 😞 75.78% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.