get-pytube / pytube3

A lightweight, dependency-free Python 3 library (and command-line utility) for downloading YouTube Videos.
https://pytube3.readthedocs.io
Other
177 stars 55 forks source link

Filter option for OTF videos that will 404 #48

Closed hbmartin closed 4 years ago

hbmartin commented 4 years ago
coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.02%) to 91.788% when pulling 8f9dd791ae5e2ca63254e2df2412710409d44701 on error-404 into ea14b7b1c04e585a5836737eb0d1483cff75466a on master.

codecov[bot] commented 4 years ago

Codecov Report

Merging #48 into master will increase coverage by 0.02%. The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   91.64%   91.67%   +0.02%     
==========================================
  Files          14       14              
  Lines         922      949      +27     
==========================================
+ Hits          845      870      +25     
- Misses         77       79       +2
Impacted Files Coverage Δ
pytube/monostate.py 86.66% <100%> (+2.05%) :arrow_up:
pytube/query.py 100% <100%> (ø) :arrow_up:
pytube/streams.py 93.49% <100%> (+0.45%) :arrow_up:
pytube/__main__.py 82.22% <42.1%> (-2.82%) :arrow_down:
pytube/extract.py 93.75% <96.15%> (+3.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea14b7b...8f9dd79. Read the comment docs.

hbmartin commented 4 years ago

@swiftyy-mage @movraxrsp I know y'all have looked into these issues before and I'm a bit nervous since taken together these are real changes to decrypting the streams. Can you take a look and try out with a few different videos?

swiftyy-mage commented 4 years ago

@hbmartin Will do.

hbmartin commented 4 years ago

@jslay88 can you try this branch and verify that it addresses #47 ? After that I can cut a release with these changes.