get-salt-AI / SaltAI

GNU General Public License v3.0
71 stars 9 forks source link

Duplicate logs after loading SaltAI nodes and comfyui slow-down #17

Closed Moj-X closed 2 months ago

Moj-X commented 2 months ago

I added several SaltAI comfy nodes and now I'm seeing duplicate logs in the terminal and Comfy runs incredibly slowly. Deleting the SaltAI custom nodes fixes the issue.

Specifically SaltAI, SaltAI_Language_Toolkit, SaltAI_LlamaIndex and SaltAI_AudioViz.

Snippet of my log during loading ComfyUI. You'll see the duplicates start to happen after the first block...

SaltAIStableVideoDiffusion [Stable Video Diffusion], SaltRGBAFromMask [Mask with Alpha (Transparency)], SAIColorTransfer [Color Transfer], SaltImageBlendingModes [Composite Images], SaltLoadImageZip [Load Images from ZIP], SaltInput [Salt Workflow Input], SaltOutput [Salt Workflow Output], SaltInfo [Salt Workflow Info], SaltCLIPSegLoader [CLIPSeg Model Loader (Salt)], SaltCLIPSegMasking [Batch Image CLIPSeg Masking], SaltCropImageLocation [Crop Batch Image Location], SaltImagePasteCrop [Crop Batch Image Paste], SaltMaskCropRegion [Mask Batch Crop Region], SaltBatchCropDataExtractor [Extract Crop Data from Batch], SaltMasksToImages [Masks to Tensors], SaltMaskDominantRegion [Dominant Mask Regions], SaltMaskMinorityRegion [Minority Mask Regions], SaltMaskArbitaryRegion [Arbitrary Mask Regions], SaltMaskSmoothRegion [Smooth Mask Regions], SaltMaskErodeRegion [Erode Mask Regions], SaltMaskSubtract [Subtract Mask Regions], SaltMaskAdd [Add Mask Regions], SaltMaskInvert [Invert Mask Regions], SaltMaskDilateRegion [Dilate Mask Regions], SaltMaskFillRegion [Fill Mask Regions], SaltMaskThresholdRegion [Threshold Mask Regions], SaltMaskFloorRegion [Floor Mask Regions], SaltMaskCeilingRegion [Ceiling Mask Regions], SaltMaskGaussianRegion [Gaussian Mask Regions], SaltMaskEdgeDetection [Edge Detect Mask Regions], SaltMaskGradientRegion [Gradient Filter Mask Regions], SaltMaskAdaptiveThresholdingRegion [Adaptive Threshold Mask Regions], SaltMaskHistogramEqualizationRegion [Hisogram Equalize Mask Regions], SaltMaskRegionLabeling [Label Mask Regions (RGB)], SaltMaskContourExtraction [Countour Mask Regions Extraction], SaltMaskBilateralFilter [Bilateral Filter Mask Regions], SaltMaskClipHardeningFilter [Clip Harden Region], SaltMaskSharpeningFilter [Sharpen Mask Regions], SaltMaskSkeletonization [Skeletonize Mask Regions], SaltMaskNoiseAddition [Add Noise to Mask Regions], SaltMaskRegionSplit [Split Regions], OPAC [OPAC Scheduler], OPACPerlinSettings [Keyframing Perlin Settings], OPAC2Floats [Keyframing Convert to FLOATS (MTB)], OPACListVariance [Apply Keyframing to List], OPACList2ExecList [Keyframing Convert Iterative Execution List], OPCScheduler [Parallax Motion Camera Scheduler], OPCSLayerExtractor [Parallax Motion Camera Scheduler Extractor], ParallaxMotion [Parallax Motion Parameters Generator], ScheduledImageAdjust [Batch Image Scheduled Adjustments], OpenAIModel [Load OpenAI LLM Model], LLMChatMessages [LLM Message], LLMChatMessagesAdv [LLM Message (Advanced)], LLMChatMessageConcat [LLM Messages Concat], LLMServiceContextDefault [LLM Service Context], LLMServiceContextAdv [LLM Service Context (Advanced)], LLMVectorStoreIndex [LLM Vector Store Index], LLMSummaryIndex [LLM Summary Index], LLMTreeIndex [LLM Tree Index], LLMSentenceSplitterNodeCreator [LLM Setence Splitter Node Creator], LLMSemanticSplitterNodeParser [LLM Semantics Splitter Node Parser], LLMQueryEngine [LLM Query Engine], LLMQueryEngineAdv [LLM Query Engine (Advanced)], LLMChatEngine [LLM Chat Engine], LLMChat [LLM Chat], LLMComplete [LLM Complete], LLMDirectoryReader [LLM Simple Directory Reader], LLMSimpleWebPageReader [LLM Simple Web Page Reader], LLMTrafilaturaWebReader [LLM Trafilatura Web Reader], LLMRssReaderNode [LLM RSS Reader], LLMNotionReader [LLM Notion Reader], LLMPostProcessDocuments [LLM Post Process Documents], LLMJsonComposer [LLM JSON Composer], LLMJsonRepair [LLM JSON Repair], LLMYamlComposer [LLM YAML Composer], LLMYamlRepair [LLM YAML Repair], LLMMarkdownComposer [LLM Markdown Composer], LLMMarkdownRepair [LLM Markdown Repair], LLMHtmlComposer [LLM HTML Composer], LLMHtmlRepair [LLM HTML Repair], LLMRegexCreator [LLM Regex Creator], LLMRegexRepair [LLM Regex Repair], SAIStringRegexSearchReplace [Regex Search and Replace], SAIStringRegexSearchMatch [Regex Search and Match], SAIPrimitiveConverter [Primitive Value Converter], SaltDisplayAny [SaltDisplayAny]

Added LoRa extension format: .results

Added LoRa extension format: .results
Using ffmpeg at C:\ProgramData\chocolatey\bin\ffmpeg.EXE
Using ffmpeg at C:\ProgramData\chocolatey\bin\ffmpeg.EXE

[Animation-Keyframing] Found `ComfyUI_ADV_CLIP_emb`. Using BLK Advanced CLIPTextEncode for Conditioning Sequencing

[Animation-Keyframing] Found `ComfyUI_ADV_CLIP_emb`. Using BLK Advanced CLIPTextEncode for Conditioning Sequencing

Import times for Salt.AI AudioViz Node Modules:
Import times for Salt.AI AudioViz Node Modules:
   0.1 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_AudioViz\nodes\audio.py
   0.1 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_AudioViz\nodes\audio.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_AudioViz\nodes\image.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_AudioViz\nodes\image.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_AudioViz\nodes\scheduling.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_AudioViz\nodes\scheduling.py

Loaded 65 Nodes:
SaltLoadAudio [Load Audio], SaltSaveAudio [Save Audio], SaltAudioFramesyncSchedule [Schedule Audio Framesync], SaltAudio2VHS [Audio to VHS Audio], SaltChangeAudioVolume [Audio Volume], SaltAudioFade [Audio Fade], SaltAudioFrequencyBoost [Audio Frequency Boost], SaltAudioFrequencyCutoff [Audio Frequency Cutoff], SaltAudioVisualizer [Audio Visualizer], SaltAudioStereoSplitter [Audio Stereo Splitter], SaltAudioMixer [Audio Mixer], SaltAudioStitcher [Audio Stitcher], SaltAudioSimpleReverb [Audio Simple Reverb], SaltAudioSimpleEcho [Audio Simple Echo], SaltAudioNormalize [Audio Normalize], SaltAudioBandpassFilter [Audio Bandpass Filter], SaltAudioCompressor [Audio Compressor], SaltAdvancedAudioCompressor [Audio Compressor Advanced], SaltAudioDeesser [Audio De-esser], SaltAudioNoiseReductionSpectralSubtraction [Audio Noise Reduction (Spectral Subtraction)], SaltAudioPitchShift [Audio Pitch Shift], SaltAudioPitchShiftScheduled [Audio Scheduled Pitch Shift], SaltAudioTrim [Audio Trim], SaltAudioRepeat [Audio Repeat], SaltAudioPlaybackRate [Audio Playback Rate], SaltAudioInversion [Audio Reverse], SaltAudioBassBoost [Audio Bass Boost], SaltAudioTrebleBoost [Audio Treble Boost], SaltAudioStereoMerge [Audio Stereo Merge], SaltAudioLDM2LoadModel [AudioLDM2 Model Loader], SaltAudioLDM2Sampler [AudioLDM2 Sampler], SaltScheduledImageAdjust [Batch Image Scheduled Adjustments], SaltScheduledShapeTransformation [Scheduled Shape Transform], SaltScheduledVoronoiNoise [Scheduled Voronoi Noise Generator], SaltScheduledPerlinPowerFractalNoise [Scheduled Perline Power Fractal Generator], SaltScheduledImageDisplacement [Scheduled Image Displacement], SaltScheduledBinaryComparison [Scheduled Binary Comparison], SaltImageComposite [Scheduled Image Composite], SaltFilmicTransitions [Image Batch Filmic Transitions], SaltOPAC [Perlin Tremor Scheduler], SaltOPACPerlinSettings [Perlin Tremor Settings], SaltScheduleConverter [Convert Schedule List], SaltScheduleVariance [Apply Easing to Schedule], SaltSchedule2ExecSchedule [Convert Schedule to Iterative Execution List], SaltLayerScheduler [Parallax Motion Camera Scheduler], SaltLayerExtractor [Parallax Motion Camera Scheduler Extractor], SaltParallaxMotion [Parallax Motion Parameter Schedule Generator], SaltFloatScheduler [Float Schedule], SaltKSamplerSequence [KSampler Scheduled Sequence], SaltCLIPTextEncodeSequence [CLIPTextEncode Scheduled Sequence], SaltConditioningSetMaskAndCombine [Conditioning Schedule Mask and Combine], SaltThresholdSchedule [Schedule Value Threshold], SaltListOperation [Schedule Numeric Operation], SaltListClamp [Schedule Numeric Clamp], SaltListLinearInterpolation [Schedule Linear Interpolation], SaltScheduleListExponentialFade [Schedule Exponential Fade], SaltScheduleRandomValues [Schedule Random Values], SaltScheduleSmoothing [Schedule Smoothing], SaltCyclicalSchedule [Schedule Cyclical Loop], SaltScheduleSplit [Schedule Split], SaltScheduleMerge [Schedule Merge], SaltKeyframeVisualizer [Schedule Visualizer], SaltKeyframeMetrics [Schedule Metrics], SaltKeyframeScheduler [Keyframe Scheduler], SaltKeyframeSchedulerBFN [Keyframe Scheduler (BIG)]

Loaded 65 Nodes:
SaltLoadAudio [Load Audio], SaltSaveAudio [Save Audio], SaltAudioFramesyncSchedule [Schedule Audio Framesync], SaltAudio2VHS [Audio to VHS Audio], SaltChangeAudioVolume [Audio Volume], SaltAudioFade [Audio Fade], SaltAudioFrequencyBoost [Audio Frequency Boost], SaltAudioFrequencyCutoff [Audio Frequency Cutoff], SaltAudioVisualizer [Audio Visualizer], SaltAudioStereoSplitter [Audio Stereo Splitter], SaltAudioMixer [Audio Mixer], SaltAudioStitcher [Audio Stitcher], SaltAudioSimpleReverb [Audio Simple Reverb], SaltAudioSimpleEcho [Audio Simple Echo], SaltAudioNormalize [Audio Normalize], SaltAudioBandpassFilter [Audio Bandpass Filter], SaltAudioCompressor [Audio Compressor], SaltAdvancedAudioCompressor [Audio Compressor Advanced], SaltAudioDeesser [Audio De-esser], SaltAudioNoiseReductionSpectralSubtraction [Audio Noise Reduction (Spectral Subtraction)], SaltAudioPitchShift [Audio Pitch Shift], SaltAudioPitchShiftScheduled [Audio Scheduled Pitch Shift], SaltAudioTrim [Audio Trim], SaltAudioRepeat [Audio Repeat], SaltAudioPlaybackRate [Audio Playback Rate], SaltAudioInversion [Audio Reverse], SaltAudioBassBoost [Audio Bass Boost], SaltAudioTrebleBoost [Audio Treble Boost], SaltAudioStereoMerge [Audio Stereo Merge], SaltAudioLDM2LoadModel [AudioLDM2 Model Loader], SaltAudioLDM2Sampler [AudioLDM2 Sampler], SaltScheduledImageAdjust [Batch Image Scheduled Adjustments], SaltScheduledShapeTransformation [Scheduled Shape Transform], SaltScheduledVoronoiNoise [Scheduled Voronoi Noise Generator], SaltScheduledPerlinPowerFractalNoise [Scheduled Perline Power Fractal Generator], SaltScheduledImageDisplacement [Scheduled Image Displacement], SaltScheduledBinaryComparison [Scheduled Binary Comparison], SaltImageComposite [Scheduled Image Composite], SaltFilmicTransitions [Image Batch Filmic Transitions], SaltOPAC [Perlin Tremor Scheduler], SaltOPACPerlinSettings [Perlin Tremor Settings], SaltScheduleConverter [Convert Schedule List], SaltScheduleVariance [Apply Easing to Schedule], SaltSchedule2ExecSchedule [Convert Schedule to Iterative Execution List], SaltLayerScheduler [Parallax Motion Camera Scheduler], SaltLayerExtractor [Parallax Motion Camera Scheduler Extractor], SaltParallaxMotion [Parallax Motion Parameter Schedule Generator], SaltFloatScheduler [Float Schedule], SaltKSamplerSequence [KSampler Scheduled Sequence], SaltCLIPTextEncodeSequence [CLIPTextEncode Scheduled Sequence], SaltConditioningSetMaskAndCombine [Conditioning Schedule Mask and Combine], SaltThresholdSchedule [Schedule Value Threshold], SaltListOperation [Schedule Numeric Operation], SaltListClamp [Schedule Numeric Clamp], SaltListLinearInterpolation [Schedule Linear Interpolation], SaltScheduleListExponentialFade [Schedule Exponential Fade], SaltScheduleRandomValues [Schedule Random Values], SaltScheduleSmoothing [Schedule Smoothing], SaltCyclicalSchedule [Schedule Cyclical Loop], SaltScheduleSplit [Schedule Split], SaltScheduleMerge [Schedule Merge], SaltKeyframeVisualizer [Schedule Visualizer], SaltKeyframeMetrics [Schedule Metrics], SaltKeyframeScheduler [Keyframe Scheduler], SaltKeyframeSchedulerBFN [Keyframe Scheduler (BIG)]

Import times for Salt.AI Language Toolkit Node Modules:
Import times for Salt.AI Language Toolkit Node Modules:
Import times for Salt.AI Language Toolkit Node Modules:
Import times for Salt.AI Language Toolkit Node Modules:
   0.3 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\autogen\__init__.py
   0.3 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\autogen\__init__.py
   0.3 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\autogen\__init__.py
   0.3 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\autogen\__init__.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\connectors.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\connectors.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\connectors.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\connectors.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\core.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\core.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\core.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\core.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\data_connector.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\data_connector.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\data_connector.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\data_connector.py
   0.1 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\llm.py
   0.1 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\llm.py
   0.1 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\llm.py
   0.1 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\llm.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\nodes_core.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\nodes_core.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\nodes_core.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\nodes_core.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\nodes_tools.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\nodes_tools.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\nodes_tools.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\nodes_tools.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\query.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\query.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\query.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\query.py
   0.4 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\readers.py
   0.4 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\readers.py
   0.4 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\readers.py
   0.4 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\readers.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\tools.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\tools.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\tools.py
   0.0 seconds: E:\Repos\ComfyUI\custom_nodes\SaltAI_Language_Toolkit\nodes\tools.py
Moj-X commented 2 months ago

I seems this issue was caused by installing all of the nodes at once thus having conflicting nodes. I didn't realise they were duplicated between repositories. Adding only SaltAI_AudioViz worked fine. Then adding SaltAI_Language_Toolkit reproduced the duplicate log issue, but the slowdown issue was fixed as there are no conflicted nodes as far as I can tell. Closing this issue as the duplicate logs issue is manageable.

conflicted_nodes