get10101 / 10101-PoC

The world needs more Lightning!
MIT License
17 stars 3 forks source link

Lightning History empty even though I opened CFD #270

Open da-kami opened 1 year ago

da-kami commented 1 year ago

I think the Lighning history should show the CFD - if it does not we have to extend it to do so. I also feel that the opening of the channel should be shown in the Lightning view - as incoming (whereas outgoing in the Bitcoin wallet...).

image

image

luckysori commented 1 year ago

I think the Lighning history should show the CFD - if it does not we have to extend it to do so. I also feel that the opening of the channel should be shown in the Lightning view - as incoming (whereas outgoing in the Bitcoin wallet...).

I think we can ignore inbound liquidity (the other party's liquidity in the channel) and focus on outbound liquidity.

For opening the channel it should be cost_of_opening_channel_on_chain - tx_fee, where cost_of_opening_channel_on_chain already takes into account the work that @da-kami did to ignore the coins that we push to the maker. It would also be cool if we could mark it as an Open channel event in the list of Lightning transactions.

Opening the CFD should always be -margin_taker. And it would be nice if it has an Open CFD label too.

bonomat commented 1 year ago

Afaik Lightning History hasn't shown CFDs so far. Only payments.

da-kami commented 1 year ago

We should finish https://github.com/itchysats/10101/issues/260 before actioning this ticket, otherwise we will likely run into conflicts.

holzeis commented 1 year ago

I would show the cfd actions only on the dashboard, otherwise it might confuse the user?

klochowicz commented 1 year ago

I would show the cfd actions only on the dashboard, otherwise it might confuse the user?

I agree.

holzeis commented 1 year ago

related to #534