get10101 / 10101-PoC

The world needs more Lightning!
MIT License
17 stars 3 forks source link

Restrict tooltip to size of Bitcoin balance #481

Closed da-kami closed 1 year ago

da-kami commented 1 year ago

The tooltip was created around the whole Row, which could cause trouble with opening the menu drawer in the Bitcoin wallet screen. The menu drawer was not properly clickable because the tooltip partly overlayed it.

Fixed by moving restricting the size of the Row to min (so it does not auto-expand) and moving the Center to the outside (it should not have been part of the Balance in the first place, the caller should decide how to layout the balance).

da-kami commented 1 year ago

Wow, I never encountered this. But I was just able to reproduce it on main following the steps you described. Sorry about that!

No worries 😊 It's partly my fault, because the Balance should have not contained the Center - this was part of the problem - and I should have probably restrained the size of the Row in the first place. Nice learnings :)

da-kami commented 1 year ago

bors r+

bors[bot] commented 1 year ago

Build succeeded: