get10101 / 10101-PoC

The world needs more Lightning!
MIT License
17 stars 3 forks source link

Display `confirmed` Bitcoin balance instead of `total` #552

Closed da-kami closed 1 year ago

da-kami commented 1 year ago

Displaying the total balance was a great idea, but it causes awkwardness because we then prominently display the maker amount being sent to the taker in the balance upon opening a channel. We cannot easily overcome this problem in the current version, so it's better to display only the confirmed balance prominently.

Additionally this causes awkwardness when we run into a channel force close, because the balance is not 0, but when trying to open a new channel we can only use 0, because our displayed balance is actually not usable.


@luckysori great composition, I think this is literally the only place I have to change :)

da-kami commented 1 year ago

bors r+

da-kami commented 1 year ago

bors r-

bors[bot] commented 1 year ago

Canceled.

da-kami commented 1 year ago

bors r+

bors[bot] commented 1 year ago

Build succeeded: