get10101 / 10101

10101 (Ten-Ten-One): Self-custodial derivative trading at your fingertips.
https://10101.finance
MIT License
130 stars 23 forks source link

Position margin disagrees with close margin after clicking `Close Position` button #2577

Closed luckysori closed 5 months ago

luckysori commented 5 months ago

image

Repro

Interestingly, this is fixed if you toy around with resizing the position first. Although we then display Margin 0 sats:

image

It would make sense to not display the margin row when closing positions.

Restioson commented 5 months ago

@holzeis: if you'd like I can take it over?

I would implement it by not showing the margin as @luckysori suggested, as it seems the simplest option (unless we have a reason to show the margin)

holzeis commented 5 months ago

Go for it 👍