getAddress / find

MIT License
0 stars 3 forks source link

Feature/leytech 20220714 #3

Open bluec opened 2 years ago

bluec commented 2 years ago

A few minor fixes and improvements...

bluec commented 2 years ago

That's a fair point especially for anyone linking to the CDN version. I have left the version suffix in there too so yes I agree the README should still link to that.

However, for anyone who uses this library via NPM and build tools like webpack etc its nice for them to have the option to not have to manually update their build with the version number each time they update the package.

bluec commented 2 years ago

I have put the version number back in the README link.

LeePaulSmith commented 2 years ago

Thanks, but if you're importing in to NPM you would use the non-versioned JS module. Only the iife version is published to the CDN: (package.json) "main": "dist/getaddress-find.mjs",

bluec commented 2 years ago

I hadn't spotted that thanks. I have reverted/removed the build changes.