search

getAlby / alby-installer-macos

GNU General Public License v3.0
6 stars 1 forks source link

Make sure we have builds for all different platforms #6

Closed bumi closed 2 years ago

bumi commented 2 years ago

What do we need to do to make sure that the app runs on all recent macs (M1, Intel, recent OS versions)? This is for the installer itself but also the companion executable. Do we need to deliver different executables for the different platforms?

stuffmc commented 2 years ago

No.

bumi commented 2 years ago

@dylancom had the issue opening the app: "you can’t open alby because it’s not supported on this mac" and I am not sure how the Rust app needs to be compiled.

bumi commented 2 years ago

the companion executable works on Intel and on M1.

we just need to make sure that the .app is available for intel and m1 and recent OS versions

bumi commented 2 years ago

so it actually seems we need to have two different executables depending on the platform. ? need to see how to create a universal binary

https://stackoverflow.com/questions/66849112/how-do-i-cross-compile-a-rust-application-from-macos-x86-to-macos-silicon

what is lipo -create?

https://github.com/rust-lang/cargo/issues/8875

stuffmc commented 2 years ago

LOL what kind of old school technology is that? Can't it produce a universal binary?! Do I to change the "path" to, say, alby-intel or alby-arm? :) I can also probably make 2 executables/.app but that isn't the way a Mac is supposed to work.

bumi commented 2 years ago

chill, I just have to learn how to build the binaries. you know web developers don't deal with this. :D and btw. Rust is younger than Swift. :)

bumi commented 2 years ago

I don't know the macOS and Rust world very well, but I think we now got universal builds: https://github.com/getAlby/alby-companion-rs#build

this release contains the latest version and should run on M1 + Intel: https://github.com/getAlby/alby-companion-rs/releases/tag/v0.5.0