getAlby / bitcoin-connect

Connecting lightning wallets to your webapp has never been easier. Enable WebLN in all browsers with a single button
https://bitcoin-connect.com
MIT License
90 stars 31 forks source link

Disconnect button draws view / UX issues with connected modal #131

Open rolznz opened 11 months ago

rolznz commented 11 months ago

image

  1. On connect, maybe we should automatically close the modal after we show the success animation rather than showing this screen. Maybe this screen should only show when the user manually clicks on the button (when you're already connected).
  2. This means the balance would not be shown on the modal by default. Is that OK?
  3. Why is the disconnect option so much easier to find than the close modal button (which could be partially fixed by 1, but might still be an issue?)
reneaaron commented 11 months ago
  1. Good point, I think that's usually a good idea (especially if the "connect" button is visible and changes state as well)
  2. :+1:
  3. Disconnect is probably a bit too prominent. Maybe we could just use the gray color here as well?
stackingsaunter commented 11 months ago
  1. Yeah, that was my intention from the beginning (sorry for bad communication).
  2. Yes.
  3. As you mentioned, in my initial idea user saw this modal only when clicked the connected button. They can see balance on the button itself, so the only thing he can do there outside is to disconnect. I think it's fine then to leave it as it is, but what @reneaaron proposed is also OK

However I think modal should also close when clicking outside of modal, which is not the case atm

stackingsaunter commented 10 months ago

I tried how it looks like when it's smaller or gray:

CleanShot 2023-12-04 at 20 17 59@2x

CleanShot 2023-12-04 at 20 18 22@2x

CleanShot 2023-12-04 at 20 18 30@2x

rolznz commented 10 months ago

I like the small gray option

stackingsaunter commented 10 months ago

Let's do it then Icon size is 12x12

image

image

image