getAlby / go

Alby Go - The easiest mobile app to use bitcoin on the Go and that works great with Alby Hub.

https://albygo.com

35 stars 4 forks source link

Number formatting #67

Open reneaaron opened 2 months ago

reneaaron commented 2 months ago

Seperate thousands by thin space (Unicode: U+2009 ( , )), If it's not easy in react, use normal space
Add crossed zeroes to all numbers
Decimals should work according to the chosen currency (I see comma as decimal for USD, which should be a dot)

reneaaron commented 2 months ago

There also seem to be some problems around the Intl bindings react native has. The option narrowSymbol doesn't seem to be available on all platforms:

https://github.com/getAlby/alby-mobile/blob/master/hooks/useGetFiatAmount.ts#L41

This makes e.g. USD display as US$ instead of just $.

bumi commented 1 month ago

Is this also related to entering decimal numbers? Currently it seems not possible to enter decimal amounts for fiat currencies.

reneaaron commented 1 month ago

140 has been a first step to address this (just changing the keyboard type), however there are some problems around number formatting / parsing (',' vs. '.' as decimal separator, etc). Probably we should support both? Need to check how other apps handle that...