getAlby / hub

Alby Hub - Your own lightning node connected to every app. Run anywhere. Become self-sovereign.
https://getalby.com
Apache License 2.0
13 stars 1 forks source link

Improve Public IP address handling #55

Open rolznz opened 2 weeks ago

rolznz commented 2 weeks ago

Currently we are broadcasting we are connectable on localhost addresses, which is bad (because from the outside this is not possible). We do this to make sure our node can be peered to (for our tests with IPv6 IPs on Fly)

From LDK:

I mean you have to decide whether you're running public routing nodes (with announced channels) or not. You can't just listen and announce wildcard IPs. If you're opening announced channels it means "these can be used for routing" and you need to provide valid addresses under which these nodes are reachable

From Olympus:

Your node is broadcasting that it is connectable @ local hosts like 0.0.0.0 and [::]

CC @bumi

bumi commented 2 weeks ago

So let's do this through the env variable