search

getAlby / hub

Alby Hub - Your own lightning node connected to every app. Run anywhere. Become self-sovereign.
https://getalby.com
Apache License 2.0
19 stars 3 forks source link

Bug: "Copy Invoice" uncaught exception in "Buy an Instant Channel" #56

Closed MegalithicBTC closed 1 week ago

MegalithicBTC commented 1 month ago

Please see screenshot below.

I would like to try to fix this issue, however I could use a little bit of direction here.

Error is happening here:

https://github.com/getAlby/bitcoin-connect/blob/b1306775814135ff7fe14e0e4758d60286321cf1/src/components/pages/bc-send-payment.ts#L213

Would you suggest that I dig into the bitcoin-connect package to try to debug this issue? Or are we using bitcoin-connect incorrectly?

copy-invoice-failure

bumi commented 4 weeks ago

In what setup are you running the app? it's likely on a non https setup?

@im-adithya you had a workaround for this case, didn't you? can you add that to bitcoin-connect, too?

MegalithicBTC commented 4 weeks ago

Yes, was a non-http setup. Closing this as it might be not be worth fixing this edge case.

bumi commented 4 weeks ago

actually it would be good to solve. if you run it at home or just on a private IP then this should also work.

rolznz commented 4 weeks ago

@im-adithya should have fixed this about a week ago in https://github.com/getAlby/nostr-wallet-connect-next/pull/440

@MegalithicBTC did you have the latest changes?

im-adithya commented 3 weeks ago

Yeah, please let us know if it breaks even after the update!

reneaaron commented 1 week ago

@im-adithya This doesn't work on Firefox on local non https domains. I've prepared a PR that seems to work:

242