getAlby / hub

Alby Hub - Your own lightning node connected to every app. Run anywhere. Become self-sovereign.
https://albyhub.com
Apache License 2.0
89 stars 17 forks source link

few bugs with phoenixd backend #62

Closed Funman2 closed 4 months ago

Funman2 commented 4 months ago

first of all really cool app!! Kudos.

I have deployed the app as a docker container with latest version, and I have an ip like this for my phoenixd instance: http://192.168...:2121 so it always tried to connect to the default ip 127.0.0.1:9740 even if i specified my correct ip in in the nwc ui app, so initially it did not work with phoenixd, but then i added an ENV variable in the container PHOENIXD_ADDRESS=http://192.168....:2121 and then it worked. Strange...😉 lol..

Also the balance is shown as a sum of fee credit and actual balance...so i have 48 sats fee credit and 11k sats balance so Nwc-next ui wallet says i have 59k sats balance so it seems to read the fee credit as actual balance.

bumi commented 4 months ago

can you try again in master. I think I just fixed this.

regarding the balance: what do you think is best to show? not show the fee credit at all? -because we can only show one balance (not two)

Funman2 commented 4 months ago

Hi cool, will try, .... It would be best to not show fee credit at all. Since it is not spendable balance. You can display that with phoenixd commands, anybody using phoenixd will know how to do that.... also it shows in phoenixd logs. So best would be to display balance in alby without fee credit. Thanks for quick reply

Funman2 commented 4 months ago

i think i can not try yet since i use the published docker container in my portainer app on umbrel...so that would not be updated yet i guess?

bumi commented 4 months ago

It should be up now. commit ef80548 https://github.com/getAlby/nostr-wallet-connect-next/pkgs/container/nostr-wallet-connect-next

Funman2 commented 4 months ago

Yes it works now, ip and password in ui. Congrats! ...looking forward for the the fix without fee credit balance.

bumi commented 4 months ago

I am updating and not counting the fee credit

bumi commented 4 months ago

changed in the latest master release.

how does it work for you? how do you like it?

Funman2 commented 4 months ago

yes it works absolutely fine now! Thanks, like it very much! Useful for nostr.

Funman2 commented 4 months ago

i have noticed though that wallet balance after sending does not update in linked alby nwc in browser extension only after a while, whereas with braydons satdress nwc it instantly updates...

bumi commented 4 months ago

yes, there is a bit of caching to increase the speed. we need to tweak this a bit