getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.
https://getalby.com/#extension
MIT License
539 stars 194 forks source link

Initial popup frontend #1

Closed bumi closed 3 years ago

bumi commented 3 years ago

Initial frontend for the extension popup including:

Current status:

https://github.com/bumi/lightning-browser-extension/blob/master/source/Popup/Popup.js

Inspiration

chris-aeviator commented 3 years ago

receive / send (links to create an invoice or pay an invoice from within the popup)

@bumi is this relevant or better the job of a wallet extension like joule

bumi commented 3 years ago

what you you mean by "better the job of a wallet extension like joule"?

chris-aeviator commented 3 years ago

I understood that you wanted this extension to not represent a full wallet , that's why I'm saying wallet extension like joule

On Apr. 21 2021, at 2:44 pm, Michael Bumann @.***> wrote:

what you you mean by "better the job of a wallet extension like joule"? — You are receiving this because you commented. Reply to this email directly, view it on GitHub (https://github.com/bumi/lightning-browser-extension/issues/1#issuecomment-824030590), or unsubscribe (https://github.com/notifications/unsubscribe-auth/ACX5BJPNOIZLBBZHSKLKB73TJ3CD5ANCNFSM4ZQYB7YA).

bumi commented 3 years ago

sorry, I still don't understand how that is related to receive / send (links to create an invoice or pay an invoice from within the popup)

with "send / receive" options I understand that the user can manually initiate a payment (by copy and paste an invoice, or an lnurl text or something like that) and also can create an invoice to receive a payment (that then needs to be provided to a website or uploaded somewhere)

For now I think this extension should not try to run a full lightning node in the browser just because I think that adds a lot of complexity and probably requires a lot of work. I'd rather for now focus on the UX of using lightning in the web. Later I think it could be cool to have a non-custodial lighting wallet in the browser (just like one on the mobile phone)

chris-aeviator commented 3 years ago

sorry, I still don't understand how that is related to receive / send (links to create an invoice or pay an invoice from within the popup)

I think it's overkill for this extension, otherwise it would just be copying what the others are doing. I believe if we focus purely on letting users pay for stuff online with our extension, and do not offer manual payment/sending we might reach a different set of users, that find 128 character hex invoices way too confusing. opensTheDiscussion 🎬

bumi commented 3 years ago

from all the confusing things I find copy a random string (like users do with IBANs and other IDs) into a field and press pay quite easy. but let's discuss that somewhere else as it is not related to this issue really.