getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.
https://getalby.com/#extension
MIT License
539 stars 194 forks source link

Show fiat rates in notifications #1381

Closed bumi closed 2 years ago

bumi commented 2 years ago

Is your feature request related to a problem? Please describe

We have now the option to show fiat amounts when we display satoshi amounts. So far we do not do this in the notifications. we should also show the same amount information.

Additional context

we need to convert the amount here: https://github.com/getAlby/lightning-browser-extension/blob/master/src/extension/background-script/events/notifications.js#L13-L23

Probably it would be helpful if we refactor the currency converter first to do the api call and caching in a background script action?

escapedcat commented 2 years ago

Blocked by #1021 and #770