search

getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.
https://getalby.com/#extension
MIT License
529 stars 193 forks source link

Notifications of new transactions on Alby icon (browser favicon) #1536

Open bitcoinuser opened 1 year ago

bitcoinuser commented 1 year ago

Is your feature request related to a problem? Please describe

Today, users are not notified of new transactions. They need to open Alby to see if they received new transactions

Describe the solution you'd like

I would like to see notifications of new transactions on Alby browser favicon Like this: https://clevertap.com/blog/app-icon-badges

escapedcat commented 1 year ago

You mean on the favicon?

bitcoinuser commented 1 year ago

You mean on the favicon?

* <img alt="image" width="42" src="https://user-images.githubusercontent.com/1016218/192678531-700a33fb-a808-4deb-83f6-771d4b940d72.png">

* ![image](https://user-images.githubusercontent.com/1016218/192678591-e5af5208-1d54-4b8d-8ab0-b5af2e73ab10.png)

Yes

reneaaron commented 1 year ago

Generally like the idea. There are badges available to display on the extension icon:

https://developer.chrome.com/docs/extensions/reference/browserAction/#method-setBadgeText browser.browserAction.setBadgeText({ text: "25" });

image

Questions to tackle:

bitcoinuser commented 1 year ago
  • When do we mark transactions as "seen"?

I think the simple action of opening Alby and clicking on Incoming tab, should mark as seen. Maybe when there are new transactions, when clicking on Alby favicon, should go directly to Incoming tab.

bitcoinuser commented 1 year ago
  • When do we mark transactions as "seen"?

I think the simple action of opening Alby and clicking on Incoming tab, should mark as seen. Maybe when there are new transactions, when clicking on Alby favicon, should go directly to Incoming tab.

Maybe on Incoming tab, have a link called (show new transactions), when the user click on it, expand the list and show the new transactions and at same time mark them as seen.

escapedcat commented 1 year ago

Maybe on Incoming tab, have a link called (show new transactions), when the user click on it, expand the list and show the new transactions and at same time mark them as seen.

We could also add a "dot" to the "incoming" tab to indicate new ones which will be removed after clicking the tab. New txs could be marked as well maybe.

Regarding using the "badgeText": Do you think there's a chance we might use this for something else in the future? Once a user is used to "these are new transactions" it might not be easy to use it for something else. Just a thought.

reneaaron commented 1 year ago

Regarding using the "badgeText": Do you think there's a chance we might use this for something else in the future? Once a user is used to "these are new transactions" it might not be easy to use it for something else. Just a thought.

Good point. We should put some thought into that. Right from the top of my head I couldn't come up with something else that would make sense in there though.

bitcoinuser commented 1 year ago

We could also add a "dot" to the "incoming" tab to indicate new ones which will be removed after clicking the tab. New txs could be marked as well maybe.

Great idea

Regarding using the "badgeText": Do you think there's a chance we might use this for something else in the future? Once a user is used to "these are new transactions" it might not be easy to use it for something else. Just a thought.

Even if there are other uses of badge, I don't see it as a problem. Badge can show 11 and I can have 10 new transactions and 1 other kind of notification.