search

getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.
https://getalby.com/#extension
MIT License
538 stars 194 forks source link

Settings: Text very close to the "switch"-button #1596

Closed bitcoinuser closed 2 years ago

bitcoinuser commented 2 years ago

Describe the bug

Text is very near the button

Screenshots of the changes [optional]

Captura de tela de 2022-10-09 11-31-20

To Reproduce

Steps to reproduce the behavior:

  1. Change language to Portuguese Brasil on settings
  2. See the LNURL-Auth antigo

Expected behavior

Text not very near the button

Alby information

Are you working on this issue?

No

vaibhavgarg237 commented 2 years ago

@escapedcat We can add mr-1 here in Settings component. It will add some space in right between the toggle button and subtitle text.

Updated image

Old image image

escapedcat commented 2 years ago

Thanks for your suggestion @vaibhavgarg237 ! You wanna create a PR?

vaibhavgarg237 commented 2 years ago

Thanks for your suggestion @vaibhavgarg237 ! You wanna create a PR?

Okay, I will open a PR. You can assign it to me.

vaibhavgarg237 commented 2 years ago

@escapedcat I have opened a PR for this issue.