Closed reneaaron closed 1 year ago
In the first step what we imo need to look at is how we can let the connector decide what currency the return amounts have. E.g. when we show the account balance we have a hard coded "sats" there. this would need to be the currency of the connector. Same in the incoming invoices. I'd also say if the currency is not btc/sats then we do not show any other fiat amount (or we show the sats amount, whatever is easier)
in the outgoing payments list I'd still try to store sats amounts.
related code; https://github.com/getAlby/lightning-browser-extension/blob/master/src/app/components/AccountMenu/index.tsx#L92-L102
=> relevant PR https://github.com/getAlby/lightning-browser-extension/pull/1774
Updated according to @bumi comment below
just for completeness: Here is the code where I explored Kollider: https://github.com/getAlby/lightning-browser-extension/pull/1770
there does not need to be a special prompt, just like other connectors need some information this needs a "currency":
I would also call it just getCurrency
- because those accounts will only have one currency I guess.
and in the first step I'd only do all this in the account menu thing. The outgoing payments are stored locally and are not per connector, there we only have the sats amounts (we don't even know the actual fiat amount that was paid from that account then)
And then we also can show the sats amount in the incoming invoices I guess.
All inputs an webln calls stay in sats.
Feature description
More and more services are offering fiat denominated accounts via synthetic assets:
Those services often offer multiple balances to their users. In Kollider's case it's:
We want to explore how this can be integrated into Alby by creating a connector for Kollider. (see WIP branch linked to this issue)
Context
When connecting a Kollider account () a user would need to choose which balance should be used within Alby, it's currently out of scope to support multiple balances.
A connector would need to signal the current currency to the extension.
Questions
Useful links
Out of scope
ToDo